Superskyyy commented on PR #276: URL: https://github.com/apache/skywalking-python/pull/276#issuecomment-1419688609
> > > > One more thing, I see that there's no use of SW_formatter meaning no support for `log_reporter_layout` right? Maybe please provide such additional information like "only built-in logging module supports this configuration blabla, lorugu doesn't support this configuration blabla" > > > > > > > > > > > > > > > > > > > > > > > > > > Same goes to `log_reporter_formatted` which is the trigger of layout. > > > > > > > > > > > > loguru's format and record are different from logging's and SW_formatter is for logging record. So i think just use loguru raw message. > > > > Provide such additional information is good. But may be it's not important now. Python Agent Log Reporter aims at logging module. loguru just use a few configuration in https://skywalking.apache.org/docs/skywalking-python/next/en/setup/configuration/#log-reporter-configurations. > > > > > > I'm just thinking a situation where user thinks some config like layout also applies to loguru so they set it but see no effect. They may get confused, so adding a comment to the config will help reduce this risk. > > > > Good, add where ? Simply add to the corresponding comment in config.py and regenerate documentation by make doc-gen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
