wu-sheng commented on a change in pull request #3273: Support Zookeeper ACL
URL: https://github.com/apache/skywalking/pull/3273#discussion_r314208393
 
 

 ##########
 File path: 
oap-server/server-cluster-plugin/cluster-zookeeper-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/zookeeper/ClusterModuleZookeeperProvider.java
 ##########
 @@ -61,7 +79,39 @@ public ClusterModuleZookeeperProvider() {
 
     @Override public void prepare() throws ServiceNotProvidedException, 
ModuleStartException {
         RetryPolicy retryPolicy = new 
ExponentialBackoffRetry(config.getBaseSleepTimeMs(), config.getMaxRetries());
-        client = CuratorFrameworkFactory.newClient(config.getHostPort(), 
retryPolicy);
+
+        CuratorFrameworkFactory.Builder builder = 
CuratorFrameworkFactory.builder()
+            .retryPolicy(retryPolicy)
+            .connectString(config.getHostPort());
+        if (config.isEnableACL()) {
+            final List<ACL> acls = Lists.newArrayList();
+
+            String authInfo = config.getAuth();
+            if ("digest".equals(config.getSchema())) {
 
 Review comment:
   I am not familiar w/ ACL, but why is `digest` schema special?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to