wu-sheng commented on code in PR #10415: URL: https://github.com/apache/skywalking/pull/10415#discussion_r1111735673
########## docs/en/changes/changes.md: ########## @@ -99,6 +99,7 @@ * Refactor http-based alarm plugins and extract common logic to `HttpAlarmCallback`. * Support Amazon Simple Storage Service (Amazon S3) metrics monitoring * Support process Sum metrics with AGGREGATION_TEMPORALITY_DELTA case +* Support prometheus HTTP API and promQL. Review Comment: ```suggestion * Support prometheus HTTP API and promQL. * `Scope` in the Entity of Metrics query v1 protocol is not required and automatical correction. The scope is determined based on the metric itself. ``` I think we should update the GraphQL to remove required and add comments about the new mechanism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
