wu-sheng commented on a change in pull request #3274: Check license header
strictly
URL: https://github.com/apache/skywalking/pull/3274#discussion_r314300439
##########
File path: apm-checkstyle/checkStyle.xml
##########
@@ -110,4 +110,11 @@
<property name="path"
value="apm-sniffer/(apm-sdk-plugin|optional-plugins)/.+/src/main/.+Instrumentation.java$"
/>
</module>
</module>
+
+ <module name="RegexpHeader">
+ <property name="headerFile" value="${checkstyle.header.file}"/>
+ <property name="multiLines" value="16"/>
+ <property name="fileExtensions" value="java"/>
Review comment:
I think header check is required in shell, bat, yaml, xml, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
