wu-sheng commented on code in PR #459:
URL: https://github.com/apache/skywalking-java/pull/459#discussion_r1112428144
##########
apm-sniffer/apm-sdk-plugin/armeria-0.85.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/armeria/Armeria085ServerInterceptor.java:
##########
@@ -32,13 +31,15 @@
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+import java.lang.reflect.Method;
+
@SuppressWarnings("unused") // actually used
public class Armeria085ServerInterceptor implements
InstanceMethodsAroundInterceptor {
@Override
public void beforeMethod(final EnhancedInstance objInst, final Method
method, final Object[] allArguments,
final Class<?>[] argumentsTypes, final
MethodInterceptResult result) {
- DefaultHttpRequest httpRequest = (DefaultHttpRequest) allArguments[1];
+ HttpRequest httpRequest = (HttpRequest) allArguments[1];
Review Comment:
I think you don't need to change this. As this plugin should only work when
version < 0.99. If not, it means you need another witness class in 0.85-0.99
plugin.
##########
apm-sniffer/apm-sdk-plugin/armeria-0.85.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/armeria/Armeria085ServerInterceptor.java:
##########
@@ -32,13 +31,15 @@
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+import java.lang.reflect.Method;
+
@SuppressWarnings("unused") // actually used
public class Armeria085ServerInterceptor implements
InstanceMethodsAroundInterceptor {
@Override
public void beforeMethod(final EnhancedInstance objInst, final Method
method, final Object[] allArguments,
final Class<?>[] argumentsTypes, final
MethodInterceptResult result) {
- DefaultHttpRequest httpRequest = (DefaultHttpRequest) allArguments[1];
+ HttpRequest httpRequest = (HttpRequest) allArguments[1];
Review Comment:
CI fails due to this.
##########
apm-sniffer/apm-sdk-plugin/apm-armeria-plugins/apm-armeria-0.99.x-plugin/src/main/resources/skywalking-plugin.def:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+armeria-0.99.0=org.apache.skywalking.apm.plugin.armeria.define.Armeria099ClientInstrumentation
Review Comment:
This is a new plugin, `plugin-list.md` and `supported-list.md` should be
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
