mufiye commented on code in PR #10449:
URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118088809
##########
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java:
##########
@@ -187,7 +187,7 @@ private static Map<Double, Long>
buildBucketsFromExponentialHistogram(
final Map<Double, Long> result = new HashMap<>();
double base = Math.pow(2.0, Math.pow(2.0, -scale));
if (base == Double.POSITIVE_INFINITY) {
- if (log.isDebugEnabled()) {
+ if (log.isWarnEnabled()) {
log.warn("Receive and reject out-of-range ExponentialHistogram
data");
}
Review Comment:
> You don't have extra operation besides the logout, then usually, with or
w/o `isWarnEnabled`, they are nearly same.
So should I delete the if judge statement? And for the error, I think it is
because I use jdk since 16. I will try to use jdk 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
