wu-sheng commented on code in PR #10448:
URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118105331
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/BanyanDBModelExtension.java:
##########
@@ -45,4 +46,23 @@ public class BanyanDBModelExtension {
@Setter
private boolean storeIDTag;
+ /**
+ * lru_size defines how many snapshots are allowed to be maintained in the
memory.
+ * The default value is 2 in the BanyanDB if not set.
+ *
+ * @since 9.4.0
+ */
+ @Getter
+ @Setter
+ private int lruSize = 2;
Review Comment:
We should have a TopN sub-class. Building this inside
`BanyanDBModelExtension` is not very clear. Especially, I think all models have
BanyanDBModelExtension, but not all of them have TopN definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
