This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch other-ttl-bug
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit 5e6b7dc7ca2f43c443d289184d9822663f8eafe7
Author: Wu Sheng <wu.sh...@foxmail.com>
AuthorDate: Fri Aug 16 22:46:04 2019 +0800

    set Override is not working.
---
 .../StorageModuleElasticsearchConfig.java           | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git 
a/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
 
b/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
index 5ba6692..e8a0fc6 100644
--- 
a/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
+++ 
b/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
@@ -47,11 +47,24 @@ public class StorageModuleElasticsearchConfig extends 
ModuleConfig {
     private int otherMetricsDataTTL = 0;
     @Setter private int monthMetricsDataTTL = 18;
 
-    public void setOtherMetricsDataTTL(int otherMetricsDataTTL) {
+    public int getMinuteMetricsDataTTL() {
         if (otherMetricsDataTTL > 0) {
-            minuteMetricsDataTTL = otherMetricsDataTTL;
-            hourMetricsDataTTL = otherMetricsDataTTL;
-            dayMetricsDataTTL = otherMetricsDataTTL;
+            return otherMetricsDataTTL;
         }
+        return minuteMetricsDataTTL;
+    }
+
+    public int getHourMetricsDataTTL() {
+        if (otherMetricsDataTTL > 0) {
+            return otherMetricsDataTTL;
+        }
+        return hourMetricsDataTTL;
+    }
+
+    public int getDayMetricsDataTTL() {
+        if (otherMetricsDataTTL > 0) {
+            return otherMetricsDataTTL;
+        }
+        return dayMetricsDataTTL;
     }
 }

Reply via email to