wu-sheng commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446371235
> > > I review the data collected from airflow and find there are some small timer data, such as 1.182709 and 1.348083 in one exponentialHistogram data. Where should I add the closure? > > > > > > When you write MAL. > > I read other services' otel rule cases and meter analysis language but have no idea how to do this. Could you explain it more? There is no other for these. Because they don't use small doubles as buckets. If you want to learn this for now, then MAL is groovy based script. `SampleFamily` is the root class running in MAL engine, and this is the type referred by the metric name of the expression. You can see `SampleFamily#filter(Closure<Boolean> filter)`, this is what I mean about closure. It means a code block as an inner class for the metric process. We don't have a similar mechanism for this, but from what you described these buckets, we seem to need one for the exponential histogram. For example, we may need `buildBucketsFromExponentialHistogram(..., Closure<Boolean> processor)` as another new method. Then we could write some codes in the MAL expression to do `mutiple 1000`(ns -> ms) mentioned above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
