lujiajing1126 commented on code in PR #257:
URL:
https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1139597264
##########
test/cases/measure/data/testdata/service_instance_cpm_minute_data.json:
##########
@@ -155,7 +155,7 @@
},
{
"str": {
- "value": "svc_3"
Review Comment:
I'm not sure if we can do this in this case.
ServiceID is not only the groupBy tag but also a part of `SeriesID` of the
source measure. It cannot be NULL?
##########
test/cases/measure/data/testdata/service_instance_cpm_minute_data.json:
##########
@@ -155,7 +155,7 @@
},
{
"str": {
- "value": "svc_3"
Review Comment:
I'm not sure if we can do this in this case.
ServiceID is not only the groupBy tag but also a part of `SeriesID` in the
source measure. It cannot be NULL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
