wu-sheng commented on code in PR #10544:
URL: https://github.com/apache/skywalking/pull/10544#discussion_r1139970652
##########
oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/TableHelper.java:
##########
@@ -125,13 +125,10 @@ public List<String> getTablesForRead(String modelName,
long timeBucketStart, lon
timeBucketStart =
TimeBucket.getTimeBucket(TimeBucket.getTimestamp(timeBucketStart),
DownSampling.Day);
timeBucketEnd =
TimeBucket.getTimeBucket(TimeBucket.getTimestamp(timeBucketEnd),
DownSampling.Day);
- final var tablesWithinTTL = new
HashSet<>(getTablesWithinTTL(modelName));
-
return LongStream
.rangeClosed(timeBucketStart, timeBucketEnd)
.distinct()
.mapToObj(it -> tableName + "_" + it)
- .filter(tablesWithinTTL::contains)
Review Comment:
I think this is a good one. Why do you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
