zbw911 commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1140128315
########## plugins/forwarder/kafka/nativetracing/forwarder.go: ########## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package nativetracing + +import ( + "fmt" + "reflect" + + "github.com/Shopify/sarama" + "google.golang.org/protobuf/proto" + + "github.com/apache/skywalking-satellite/internal/pkg/config" + "github.com/apache/skywalking-satellite/internal/pkg/log" + "github.com/apache/skywalking-satellite/internal/satellite/event" + + v3 "skywalking.apache.org/repo/goapi/collect/language/agent/v3" + v1 "skywalking.apache.org/repo/goapi/satellite/data/v1" +) + +const ( + Name = "native-tracing-kafka-forwarder" + ShowName = "Native Tracing Kafka Forwarder" +) + +type Forwarder struct { + config.CommonFields + Topic string `mapstructure:"topic"` // The forwarder topic. + producer sarama.SyncProducer +} + +func (f *Forwarder) Name() string { + return Name +} + +func (f *Forwarder) ShowName() string { + return ShowName +} + +func (f *Forwarder) Description() string { + return "This is a synchronization Kafka forwarder with the SkyWalking native log protocol." +} + +func (f *Forwarder) DefaultConfig() string { + return ` +# The remote topic. +topic: "skywalking-segments" +` +} + +func (f *Forwarder) Prepare(connection interface{}) error { + client, ok := connection.(sarama.Client) + if !ok { + return fmt.Errorf("the %s only accepts a grpc client, but received a %s", + f.Name(), reflect.TypeOf(connection).String()) + } + producer, err := sarama.NewSyncProducerFromClient(client) + if err != nil { + return err + } + f.producer = producer + return nil +} + +func (f *Forwarder) Forward(batch event.BatchEvents) error { + var message []*sarama.ProducerMessage + for _, e := range batch { + switch data := e.GetData().(type) { + case *v1.SniffData_Segment: + segmentObject := &v3.SegmentObject{} + err := proto.Unmarshal(data.Segment, segmentObject) + if err != nil { + return err + } + + message = append(message, &sarama.ProducerMessage{ + Topic: f.Topic, + Key: sarama.StringEncoder(segmentObject.GetTraceSegmentId()), + Value: sarama.ByteEncoder(data.Segment), + }) + case *v1.SniffData_SpanAttachedEvent: + // SniffData_SpanAttachedEvent is from ebpf agent, skywalking-rover project. + // You could find it here, + // https://github.com/apache/skywalking-data-collect-protocol/blob/0da9c8b3e111fb51c9f8854cae16d4519462ecfe + // /language-agent/Tracing.proto#L244 + // ref: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1136909393 + log.Logger.WithField("pipe", f.PipeName).Warnf("native-tracing-kafka-forwarder " + Review Comment: > It should be works well with windows. Could you provide more detail about the error? the example of skywalking-infra-e2e: 1，windows CMD: ``` F:\github\apache\skywalking-infra-e2e\bin\windows>.\e2e.exe run -c ../../examples/compose/e2e.yaml INFO load the e2e config successfully : invalid reference format: no such image: apache/skywalking-oap-server:8.5.0-es6 INFO deleting docker compose cluster... INFO cleanup part finished successfully ERROR Local Docker compose exited abnormally whilst running docker-compose.exe: [--env-file F:\github\apache\skywalking-infra-e2e\examples\compose\env up -d]. exit status 1 ``` 2，windows PowerShell: ``` PS F:\github\apache\skywalking-infra-e2e\bin\windows> .\e2e.exe run -c ../../examples/compose/e2e.yaml INFO load the e2e config successfully : invalid reference format: no such image: apache/skywalking-ui:8.5.0 INFO deleting docker compose cluster... INFO cleanup part finished successfully ERROR Local Docker compose exited abnormally whilst running docker-compose.exe: [--env-file F:\github\apache\skywalking-infra-e2e\examples\compose\env up -d]. exit status 1 ``` 3，WSL 2: ``` root@DESKTOP-P1D7M3U:/mnt/f/github/apache/skywalking-infra-e2e/bin/linux# e2e run -c ../../examples/compose/e2e.yaml INFO load the e2e config successfully : invalid reference format: no such image: apache/skywalking-ui:8.5.0 INFO deleting docker compose cluster... INFO cleanup part finished successfully ERROR Local Docker compose exited abnormally whilst running docker-compose: [--env-file /mnt/f/github/apache/skywalking-infra-e2e/examples/compose/env up -d]. exit status 1 ``` docker-compose : ``` root@DESKTOP-P1D7M3U:/mnt/f/github/apache/skywalking-infra-e2e/examples/compose# docker-compose --env-file=./env up -d [+] Running 2/2 ⠿ Container compose-oap-1 Healthy 11.6s ⠿ Container compose-ui-1 Started ``` I have been able to successfully start using the docker-compose command on both Windows and WSL. However, I have never been successful in using the e2e command directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
