jiang1997 commented on code in PR #297: URL: https://github.com/apache/skywalking-python/pull/297#discussion_r1147600939
########## .github/workflows/publish-docker.yaml: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: publish-docker + +on: + push: + branches: + - master + +env: + HUB: ghcr.io/apache/skywalking-python + PROJECT: skywalking-python + +jobs: + build-docker: + if: github.repository == 'apache/skywalking-python' + runs-on: ubuntu-latest + permissions: + contents: read + packages: write + timeout-minutes: 30 + env: + VERSION: ${{ github.sha }} + steps: + - uses: actions/checkout@v2 + with: + submodules: true + - name: Log in to the Container registry + uses: docker/[email protected] + with: + registry: ${{ env.HUB }} + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} + - name: Build and push docker image + run: | + make push-image Review Comment: I have tried `make -j 10 push-image`, but seems that `docker buildx` can't run parallel. Firstly, container `skywalking_python_main` can't be shared between parallel building tasks, secondly, even though we create target-specific containers, because [this line](https://github.com/jiang1997/skywalking-python/blob/a2584055130f5b8eb2f0c474bbac8213eef2094c/docker/Makefile#L81) works at system level, CI still runs into errors. After some digging, I found that the most time-consuming step is building gRPC related whl packages when building image for arm64 `python3.11`. Cuz there is no needed binary whl package off the shelf so far. https://github.com/grpc/grpc/issues/32454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
