innerpeacez commented on code in PR #10690: URL: https://github.com/apache/skywalking/pull/10690#discussion_r1167878602
########## oap-server/server-starter/src/main/resources/ui-initialized-templates/elasticsearch/elasticsearch-cluster.json: ########## @@ -0,0 +1,454 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +[ + { + "id": "Elasticsearch-Cluster", + "configuration": { + "children":[ + { + "x":0, + "y":0, + "w":24, + "h":56, + "i":"0", + "type":"Tab", + "id":"0", + "metricTypes":[ + "" + ], + "metrics":[ + "" + ], + "activedTabIndex":0, + "children":[ + { + "name":"Overview", + "children":[ + { + "x":0, + "y":0, + "w":3, + "h":6, + "i":"0", + "type":"Widget", + "id":"0-0-0", + "metricTypes":[ + "readLabeledMetricsValues" + ], + "metrics":[ + "meter_elasticsearch_cluster_health_status" + ], + "moved":false, + "graph":{ + "type":"Table", + "showTableValues":false, + "tableHeaderCol1":"status", + "tableHeaderCol2":"" + }, + "widget":{ + "title":"Cluster health" + } + }, + { + "x":15, + "y":0, + "w":3, + "h":6, + "i":"1", + "type":"Widget", + "id":"0-0-1", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_nodes" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":true + }, + "widget":{ + "title":"Data nodes" + } + }, + { + "x":12, + "y":0, + "w":3, + "h":6, + "i":"2", + "type":"Widget", + "id":"0-0-2", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_nodes" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":true + }, + "widget":{ + "title":"Nodes" + } + }, + { + "x":18, + "y":0, + "w":3, + "h":6, + "i":"3", + "type":"Widget", + "id":"0-0-3", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_pending_tasks_total" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":true + }, + "widget":{ + "title":"Pending tasks" + } + }, + { + "x":0, + "y":6, + "w":4, + "h":5, + "i":"4", + "type":"Widget", + "id":"0-0-4", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_primary_shards_total" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":false + }, + "widget":{ + "title":"Active primary shards" + } + }, + { + "x":4, + "y":6, + "w":4, + "h":5, + "i":"5", + "type":"Widget", + "id":"0-0-5", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_shards_total" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":false + }, + "widget":{ + "title":"Active shards" + } + }, + { + "x":8, + "y":6, + "w":4, + "h":5, + "i":"6", + "type":"Widget", + "id":"0-0-6", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_initializing_shards_total" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":false + }, + "widget":{ + "title":"Initializing shards" + } + }, + { + "x":16, + "y":6, + "w":4, + "h":5, + "i":"7", + "type":"Widget", + "id":"0-0-7", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_delayed_unassigned_shards_total" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":false + }, + "widget":{ + "title":"Delayed unassigned shards" + } + }, + { + "x":20, + "y":6, + "w":4, + "h":5, + "i":"8", + "type":"Widget", + "id":"0-0-8", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_relocating_shards_total" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":false + }, + "widget":{ + "title":"Relocating shards" + } + }, + { + "x":12, + "y":6, + "w":4, + "h":5, + "i":"9", + "type":"Widget", + "id":"0-0-9", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_unassigned_shards_total" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":false + }, + "widget":{ + "title":"Unassigned shards" + } + }, + { + "x":3, + "y":0, + "w":3, + "h":6, + "i":"12", + "type":"Widget", + "id":"0-0-12", + "metricTypes":[ + "readMetricsValues" + ], + "metrics":[ + "meter_elasticsearch_cluster_breakers_tripped" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":true + }, + "widget":{ + "title":"Tripped of breakers" + } + }, + { + "x":6, + "y":0, + "w":3, + "h":6, + "i":"13", + "type":"Widget", + "id":"0-0-13", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_cpu_usage_avg" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":true + }, + "widget":{ + "title":"CPU usage Avg (%)" + } + }, + { + "x":9, + "y":0, + "w":3, + "h":6, + "i":"14", + "type":"Widget", + "id":"0-0-14", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_jvm_memory_used_avg" + ], + "moved":false, + "graph":{ + "type":"Card", + "fontSize":14, + "textAlign":"center", + "showUnit":true + }, + "widget":{ + "title":"JVM memory used Avg (%)" + } + }, + { + "x":21, + "y":0, + "w":3, + "h":6, + "i":"15", + "type":"Widget", + "id":"0-0-15", + "metricTypes":[ + "readMetricsValue" + ], + "metrics":[ + "meter_elasticsearch_cluster_open_file_descriptors" Review Comment: > 1. You should keep upper/lower cases consistent. Such as put all first letters of words in upper case. > 2. `/s` should be `(/s)` or `Per Second` > > After the e2e tests added and merged, you should update showcase to add ElasticSearch monitoring too. Sure, I will write a showcase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
