kezhenxu94 commented on code in PR #125:
URL:
https://github.com/apache/skywalking-showcase/pull/125#discussion_r1174552306
##########
deploy/platform/kubernetes/Makefile:
##########
@@ -136,6 +136,13 @@ feature-kubernetes-monitor:
$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
kube-state-metrics.enabled=true)
$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set opentelemetry.enabled=true)
+.PHONY: feature-elasticsearch-monitor
+feature-elasticsearch-monitor:
+ $(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
features.elasticsearchMonitor.enabled=true)
+ $(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
prometheus-elasticsearch-exporter.enabled=true)
+ $(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
prometheus-elasticsearch-exporter.es.uri=http://elasticsearch-master:9200)
Review Comment:
> Would this work?
>
>
>
>
>
> Otherwise, we will have to mock a new ES.
>
>
This doesn't work as expected. The `elasticsearch` feature will install ES
but if the user also set `postgresql` feature, which one will the OAP store
data is not determined and might be unexpected. Also if the data is stored in
psql the ES will have no traffic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
