sonatype-lift[bot] commented on code in PR #310: URL: https://github.com/apache/skywalking-python/pull/310#discussion_r1204611352
########## skywalking/bootstrap/hooks/uwsgi_hook.py: ########## @@ -35,6 +35,7 @@ """ from uwsgidecorators import postfork from skywalking import agent, config +from skywalking.trace import GlobalIDGenerator Review Comment: <picture><img alt="6% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg";></picture> <b>*[E0611](https://pylint.readthedocs.io/en/v2.17.1/user_guide/messages/error/no-name-in-module.html):</b>* No name 'GlobalIDGenerator' in module 'skywalking.trace' --- <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> commands</summary> You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings. | **Command** | **Usage** | | ------------- | ------------- | | `@sonatype-lift ignore` | Leave out the above finding from this PR | | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR | | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file | **Note:** When talking to LiftBot, you need to **refresh** the page to see its response. <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details> ########## skywalking/bootstrap/hooks/uwsgi_hook.py: ########## @@ -35,6 +35,7 @@ """ from uwsgidecorators import postfork from skywalking import agent, config +from skywalking.trace import GlobalIDGenerator Review Comment: <picture><img alt="13% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/13/display.svg";></picture> <b>*reportGeneralTypeIssues:</b>* "GlobalIDGenerator" is unknown import symbol --- <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> commands</summary> You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings. | **Command** | **Usage** | | ------------- | ------------- | | `@sonatype-lift ignore` | Leave out the above finding from this PR | | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR | | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file | **Note:** When talking to LiftBot, you need to **refresh** the page to see its response. <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg"){kind=link}
![https://lift.sonatype.com/api/commentimage/fixrate/13/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/13/display.svg"){kind=link}