wu-sheng commented on code in PR #10878:
URL: https://github.com/apache/skywalking/pull/10878#discussion_r1214339128
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/continuous/ContinuousProfilingQueryService.java:
##########
@@ -76,10 +119,118 @@ public List<ContinuousProfilingPolicyTarget>
queryContinuousProfilingServiceTarg
return result;
}).collect(Collectors.toList());
- return ContinuousProfilingPolicyTarget.builder()
+ final ContinuousProfilingPolicyTarget target =
ContinuousProfilingPolicyTarget.builder()
.type(type)
.checkItems(items)
.build();
+
+
Optional.ofNullable(summaryMap.get(EBPFProfilingTargetType.valueOf(type).value()))
+ .ifPresent(summary -> {
+ target.setTriggeredCount(summary.getCount());
+
target.setLastTriggerTimestamp(summary.getLastTriggerTime());
+ });
+ return target;
}).collect(Collectors.toList());
}
+
+ public List<ContinuousProfilingMonitoringInstance>
queryContinuousProfilingMonitoringInstances(String serviceId,
ContinuousProfilingTargetType target) throws IOException {
+ // query all processes under same service
+ final List<Process> processes =
getMetadataQueryDAO().listProcesses(serviceId, null, 0, 0);
+ if (CollectionUtils.isEmpty(processes)) {
+ return Collections.emptyList();
+ }
+ // query all triggered tasks
+ final List<EBPFProfilingTaskRecord> records =
queryRecentTriggeredTasks(serviceId, List.of(target));
+
+ // query instances metadata
Review Comment:
```suggestion
// query the metadata of instances
```
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/continuous/ContinuousProfilingQueryService.java:
##########
@@ -76,10 +119,118 @@ public List<ContinuousProfilingPolicyTarget>
queryContinuousProfilingServiceTarg
return result;
}).collect(Collectors.toList());
- return ContinuousProfilingPolicyTarget.builder()
+ final ContinuousProfilingPolicyTarget target =
ContinuousProfilingPolicyTarget.builder()
.type(type)
.checkItems(items)
.build();
+
+
Optional.ofNullable(summaryMap.get(EBPFProfilingTargetType.valueOf(type).value()))
+ .ifPresent(summary -> {
+ target.setTriggeredCount(summary.getCount());
+
target.setLastTriggerTimestamp(summary.getLastTriggerTime());
+ });
+ return target;
}).collect(Collectors.toList());
}
+
+ public List<ContinuousProfilingMonitoringInstance>
queryContinuousProfilingMonitoringInstances(String serviceId,
ContinuousProfilingTargetType target) throws IOException {
+ // query all processes under same service
+ final List<Process> processes =
getMetadataQueryDAO().listProcesses(serviceId, null, 0, 0);
+ if (CollectionUtils.isEmpty(processes)) {
+ return Collections.emptyList();
+ }
+ // query all triggered tasks
+ final List<EBPFProfilingTaskRecord> records =
queryRecentTriggeredTasks(serviceId, List.of(target));
+
+ // query instances metadata
Review Comment:
```suggestion
// Query the metadata of instances
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
