wu-sheng commented on code in PR #10884: URL: https://github.com/apache/skywalking/pull/10884#discussion_r1220536341
########## oap-server/ai-pipeline/src/main/java/org/apache/skywalking/oap/server/ai/pipeline/services/HttpUriRecognitionService.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.ai.pipeline.services; + +import java.util.List; +import org.apache.skywalking.oap.server.ai.pipeline.services.api.HttpUriRecognition; + +public class HttpUriRecognitionService implements HttpUriRecognition { + @Override + public void recognize(final String serviceId, final List<HTTPUri> unrecognizedURIs, final Callback callback) { + Review Comment: @Superskyyy This is for the whole process. `serviceId` and `unrecognizedURIs` are the raw data for you. `callback` will return the patterns to the kernel. Nothing more. I feel you are being held by your old design. I am repeating myself again, runtime matching(including further metrics baseline calculation for alerting) is not an AI part responsibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
