jiekun commented on PR #55: URL: https://github.com/apache/skywalking-go/pull/55#issuecomment-1579802069
Well I have little experience with code generation and ast parsing. I think I would prefer some help here (orz). Not sure how it could perform tho, like rebasing a new branch with the rewritten support for `switch-case`? I would like to provide my guess of the missing supports: 1. `switch-case` as addressed above: https://github.com/apache/skywalking-go/pull/55/files#diff-67660820b0f7f0cf5ec1b1c22b073b5005a83ac5112535be7b54863f2f4d332dR43 2. It looks like `const` (`redis.Nil`) is not rewritten as well: https://github.com/apache/skywalking-go/pull/55/files#diff-9bfc186e1c784e2abf6fe20c851745fcc16d1f4719051e1ff95e077047245445R163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
