mrproliu commented on code in PR #56:
URL: https://github.com/apache/skywalking-go/pull/56#discussion_r1222428282
##########
.github/workflows/plugin-tests.yaml:
##########
@@ -85,18 +98,58 @@ jobs:
if: ${{ failure() }}
with:
path: test/plugins/workspace
- name: test-plugins-workspace-${{ matrix.case }}
+ name: test-plugins-workspace-${{ matrix.case }}-ubuntu
+
+ test-on-macos:
+ if: always()
+ name: gin-macos
+ needs:
+ - build
+ runs-on: macos-latest
+ timeout-minutes: 90
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - uses: actions/download-artifact@v2
+ with:
+ name: test-tools-macos
+ path: test/plugins/dist
+ - name: Setup docker (missing on MacOS)
+ if: runner.os == 'macos'
+ run: |
+ brew install docker docker-compose
+ colima start
+
+ # For testcontainers to find the Colima socket
+ #
https://github.com/abiosoft/colima/blob/main/docs/FAQ.md#cannot-connect-to-the-docker-daemon-at-unixvarrundockersock-is-the-docker-daemon-running
+ sudo ln -sf $HOME/.colima/default/docker.sock /var/run/docker.sock
+ - name: Setup Tools
+ run: |
+ chmod +x test/plugins/dist/*
+ if ls test/plugins/dist/skywalking-agent-test-validator-1.0.0.tgz;
then
+ docker load -i
test/plugins/dist/skywalking-agent-test-validator-1.0.0.tgz
+ fi
+ - name: Run Test
+ run: bash test/plugins/run.sh gin
+ - uses: actions/upload-artifact@v2
+ name: Upload Agent
+ if: ${{ failure() }}
+ with:
+ path: test/plugins/workspace
+ name: test-plugins-workspace-gin-macos
required:
if: always()
name: Plugin Tests
needs:
- test
+ - test-on-macos
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- name: Merge Requirement
run: |
if [[ ${{ needs.test.result }} != 'success' ]]; then
exit -1
- fi
Review Comment:
Please add the MacOs test result checker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
