gzlicanyi commented on code in PR #555:
URL: https://github.com/apache/skywalking-java/pull/555#discussion_r1232052246
##########
apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-2.0.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v20x/HttpClientRequestInterceptor.java:
##########
@@ -80,7 +84,7 @@ public Publisher<Void> apply(final HttpClientRequest
httpClientRequest) {
}
};
- objInst.setSkyWalkingDynamicField(new EnhanceCacheObject(span,
abstractSpan));
+ ENHANCE_CONTEXT.set(new EnhanceCacheObject(span, abstractSpan));
Review Comment:
In the beforeMethod method, the name of the thread is passed to
EnhanceCacheObject, but in the afterMethod method, when it is retrieved and
compared to the current thread, they are not consistent, and the URL is also
not consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
