This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a commit to branch feature/remove-id in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
commit 2808cbaa7f6e9e41adc592d4d1dde7d754c44436 Author: Megrez Lu <[email protected]> AuthorDate: Sun Jun 18 20:30:44 2023 +0800 remove ID --- .../apache/skywalking/banyandb/v1/client/RowEntity.java | 2 -- .../banyandb/v1/client/metadata/TagFamilySpec.java | 16 +--------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java b/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java index 9a0a975..4b0dfd4 100644 --- a/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java +++ b/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java @@ -74,8 +74,6 @@ public class RowEntity { return tagValue.getStrArray().getValueList(); case BINARY_DATA: return tagValue.getBinaryData().toByteArray(); - case ID: - return tagValue.getId().getValue(); default: throw new IllegalStateException("illegal type of TagValue"); } diff --git a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java index 89bae1e..0558d86 100644 --- a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java +++ b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java @@ -98,9 +98,6 @@ public abstract class TagFamilySpec implements Serializable<BanyandbDatabase.Tag case TAG_TYPE_DATA_BINARY: builder.addTagSpec(TagFamilySpec.TagSpec.newBinaryTag(tagName)); break; - case TAG_TYPE_ID: - builder.addTagSpec(TagFamilySpec.TagSpec.newIDTag(tagName)); - break; default: throw new IllegalStateException("unrecognized tag type"); } @@ -182,16 +179,6 @@ public abstract class TagFamilySpec implements Serializable<BanyandbDatabase.Tag return new TagSpec(name, TagType.BINARY); } - /** - * create a ID tag spec - * - * @param name the name of the tag - * @return a binary array tag spec - */ - private static TagSpec newIDTag(final String name) { - return new TagSpec(name, TagType.ID); - } - /** * Set the tag to indexed_only */ @@ -215,8 +202,7 @@ public abstract class TagFamilySpec implements Serializable<BanyandbDatabase.Tag STRING(BanyandbDatabase.TagType.TAG_TYPE_STRING), INT_ARRAY(BanyandbDatabase.TagType.TAG_TYPE_INT_ARRAY), STRING_ARRAY(BanyandbDatabase.TagType.TAG_TYPE_STRING_ARRAY), - BINARY(BanyandbDatabase.TagType.TAG_TYPE_DATA_BINARY), - ID(BanyandbDatabase.TagType.TAG_TYPE_ID); + BINARY(BanyandbDatabase.TagType.TAG_TYPE_DATA_BINARY); @Getter(AccessLevel.PRIVATE) private final BanyandbDatabase.TagType tagType;
