This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch main
in repository 
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git


The following commit(s) were added to refs/heads/main by this push:
     new 9ef639a  Remove ID related APIs (#41)
9ef639a is described below

commit 9ef639a8ac086a6070d4ad91794100f5dd6c95f6
Author: Jiajing LU <[email protected]>
AuthorDate: Sun Jun 18 21:11:14 2023 +0800

    Remove ID related APIs (#41)
---
 CHANGES.md                                               |  1 +
 .../apache/skywalking/banyandb/v1/client/RowEntity.java  |  2 --
 .../banyandb/v1/client/metadata/TagFamilySpec.java       | 16 +---------------
 3 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/CHANGES.md b/CHANGES.md
index 88cdb68..5f403a7 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -7,6 +7,7 @@ Release Notes.
 
 ### Features
 * Support new TopN query protocol
+* Remove ID type of TAG
 
 0.3.1
 ------------------
diff --git 
a/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java 
b/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java
index 9a0a975..4b0dfd4 100644
--- a/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java
+++ b/src/main/java/org/apache/skywalking/banyandb/v1/client/RowEntity.java
@@ -74,8 +74,6 @@ public class RowEntity {
                 return tagValue.getStrArray().getValueList();
             case BINARY_DATA:
                 return tagValue.getBinaryData().toByteArray();
-            case ID:
-                return tagValue.getId().getValue();
             default:
                 throw new IllegalStateException("illegal type of TagValue");
         }
diff --git 
a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java
 
b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java
index 89bae1e..0558d86 100644
--- 
a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java
+++ 
b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/TagFamilySpec.java
@@ -98,9 +98,6 @@ public abstract class TagFamilySpec implements 
Serializable<BanyandbDatabase.Tag
                 case TAG_TYPE_DATA_BINARY:
                     
builder.addTagSpec(TagFamilySpec.TagSpec.newBinaryTag(tagName));
                     break;
-                case TAG_TYPE_ID:
-                    
builder.addTagSpec(TagFamilySpec.TagSpec.newIDTag(tagName));
-                    break;
                 default:
                     throw new IllegalStateException("unrecognized tag type");
             }
@@ -182,16 +179,6 @@ public abstract class TagFamilySpec implements 
Serializable<BanyandbDatabase.Tag
             return new TagSpec(name, TagType.BINARY);
         }
 
-        /**
-         * create a ID tag spec
-         *
-         * @param name the name of the tag
-         * @return a binary array tag spec
-         */
-        private static TagSpec newIDTag(final String name) {
-            return new TagSpec(name, TagType.ID);
-        }
-
         /**
          * Set the tag to indexed_only
          */
@@ -215,8 +202,7 @@ public abstract class TagFamilySpec implements 
Serializable<BanyandbDatabase.Tag
             STRING(BanyandbDatabase.TagType.TAG_TYPE_STRING),
             INT_ARRAY(BanyandbDatabase.TagType.TAG_TYPE_INT_ARRAY),
             STRING_ARRAY(BanyandbDatabase.TagType.TAG_TYPE_STRING_ARRAY),
-            BINARY(BanyandbDatabase.TagType.TAG_TYPE_DATA_BINARY),
-            ID(BanyandbDatabase.TagType.TAG_TYPE_ID);
+            BINARY(BanyandbDatabase.TagType.TAG_TYPE_DATA_BINARY);
 
             @Getter(AccessLevel.PRIVATE)
             private final BanyandbDatabase.TagType tagType;

Reply via email to