weixiang1862 commented on PR #560: URL: https://github.com/apache/skywalking-java/pull/560#issuecomment-1600437577
> I am a little confused, why shade? Checkstyle requires sourcecode package name must start with `org.apache.skywalking.apm.plugin`, so i put websphere fake class under `org.apache.skywalking.apm.plugin.webspheresource.com.ibm.ws.webcontainer.async`. If not shade, websphere runtime will throw java.lang.NoClassDefFoundError for `org.apache.skywalking.apm.plugin.webspheresource.com.ibm.ws.webcontainer.async.CompleteRunnable.class` missing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
