wu-sheng commented on code in PR #122:
URL:
https://github.com/apache/skywalking-query-protocol/pull/122#discussion_r1241581385
##########
ui-configuration.graphqls:
##########
@@ -23,11 +23,26 @@ type DashboardConfiguration {
configuration: String!
}
+type MenuItem {
+ # Display name
+ name: String!
+ # Showing icon
+ icon: String
+ # Link path
+ path: String!
+ # Whether to activate the menu or not
Review Comment:
```suggestion
# Activated menu should be listed on the menu,
# otherwise, it should stay in marketplace.
```
##########
ui-configuration.graphqls:
##########
@@ -23,11 +23,26 @@ type DashboardConfiguration {
configuration: String!
}
+type MenuItem {
+ # Display name
+ name: String!
+ # Showing icon
Review Comment:
Is this icon name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
