sonatype-lift[bot] commented on code in PR #11005:
URL: https://github.com/apache/skywalking/pull/11005#discussion_r1245235045
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java:
##########
@@ -212,6 +212,11 @@ public class CoreModuleConfig extends ModuleConfig {
*/
private int maxHttpUrisNumberPerService = 3000;
+ /**
+ * The UI menu should activate fetch interval, default 20s
+ */
+ private int uiMenuFetchInterval = 20;
Review Comment:
<picture><img alt="4% of developers fix this issue"
src="https://lift.sonatype.com/api/commentimage/fixrate/4/display.svg";></picture>
<b>*[UnnecessarilyFullyQualified](https://errorprone.info/bugpattern/UnnecessarilyFullyQualified):</b>*
This fully qualified name is unambiguous to the compiler if imported.
---
```suggestion
private String Generated
```
ââ <b>3 similar findings have been found in this PR</b>
<details><summary>đ Expand here to view all instances of this
finding</summary><br/>
<div align=\"center\">
| **File Path** | **Line Number** |
| ------------- | ------------- |
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java
|
[213](https://github.com/apache/skywalking/blob/9bca126aac192de3680f07b4e94892b4df8f6da5/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java#L213)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java
|
[213](https://github.com/apache/skywalking/blob/9bca126aac192de3680f07b4e94892b4df8f6da5/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java#L213)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java
|
[218](https://github.com/apache/skywalking/blob/9bca126aac192de3680f07b4e94892b4df8f6da5/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java#L218)
|
<p><a
href="https://lift.sonatype.com/results/github.com/apache/skywalking/01H40W8B6MJMTE2X8WSFW4KNJM?t=ErrorProne|UnnecessarilyFullyQualified"
target="_blank">Visit the Lift Web Console</a> to find more details in your
report.</p></div></details>
---
<details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b>
commands</summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.query.type;
+
+import lombok.Data;
+
+import java.util.List;
+
+@Data
+public class MenuItem {
+ private String name;
+ private String icon;
+ private String path;
Review Comment:
<picture><img alt="4% of developers fix this issue"
src="https://lift.sonatype.com/api/commentimage/fixrate/4/display.svg";></picture>
<b>*[UnnecessarilyFullyQualified](https://errorprone.info/bugpattern/UnnecessarilyFullyQualified):</b>*
This fully qualified name is unambiguous to the compiler if imported.
---
```suggestion
SuppressWarnings
```
ââ <b>14 similar findings have been found in this PR</b>
<details><summary>đ Expand here to view all instances of this
finding</summary><br/>
<div align=\"center\">
| **File Path** | **Line Number** |
| ------------- | ------------- |
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[25](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L25)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[27](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L27)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[28](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L28)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[27](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L27)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[31](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L31)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[30](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L30)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[30](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L30)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[25](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L25)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[25](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L25)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java
|
[25](https://github.com/apache/skywalking/blob/c9c4e25a5c518441a0a230a3a2fe07c53c51e6f2/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/type/MenuItem.java#L25)
|
<p> Showing <b>10</b> of <b> 14 </b> findings. <a
href="https://lift.sonatype.com/results/github.com/apache/skywalking/01H40W9KVRY9JDT9HCZBYSE88K?t=ErrorProne|UnnecessarilyFullyQualified"
target="_blank">Visit the Lift Web Console</a> to see all.</p></div></details>
---
<details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b>
commands</summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.management.ui.menu;
+
+import lombok.Data;
+
+import java.util.List;
+
+@Data
+public class UIMenuItemSetting {
+ /**
+ * Name of the menu item.
+ */
+ private String name;
Review Comment:
<picture><img alt="4% of developers fix this issue"
src="https://lift.sonatype.com/api/commentimage/fixrate/4/display.svg";></picture>
<b>*[UnnecessarilyFullyQualified](https://errorprone.info/bugpattern/UnnecessarilyFullyQualified):</b>*
This fully qualified name is unambiguous to the compiler if imported.
---
```suggestion
Generated
```
ââ <b>16 similar findings have been found in this PR</b>
<details><summary>đ Expand here to view all instances of this
finding</summary><br/>
<div align=\"center\">
| **File Path** | **Line Number** |
| ------------- | ------------- |
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[25](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L25)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java
|
[218](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java#L218)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[46](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L46)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[42](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L42)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[25](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L25)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[30](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L30)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[34](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L34)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[42](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L42)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[38](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L38)
|
|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java
|
[25](https://github.com/apache/skywalking/blob/252e5704cfe9b89694e51994e420dc61b6e7284a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/menu/UIMenuItemSetting.java#L25)
|
<p> Showing <b>10</b> of <b> 16 </b> findings. <a
href="https://lift.sonatype.com/results/github.com/apache/skywalking/01H40WABDFN7CVE40TK08B97ZM?t=ErrorProne|UnnecessarilyFullyQualified"
target="_blank">Visit the Lift Web Console</a> to see all.</p></div></details>
---
<details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b>
commands</summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://lift.sonatype.com/api/commentimage/fixrate/4/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/4/display.svg"){kind=link}