hanahmily commented on code in PR #261:
URL:
https://github.com/apache/skywalking-banyandb/pull/261#discussion_r1252874619
##########
CHANGES.md:
##########
@@ -27,6 +27,7 @@ Release Notes.
- [UI] Add measure CRUD operations.
- [UI] Add indexRule CRUD operations.
- [UI] Add indexRuleBinding CRUD operations.
+- Implement Write-ahead Logging
Review Comment:
Move it to 0.5.0
##########
api/common/id.go:
##########
@@ -40,6 +40,27 @@ func (s SeriesID) Marshal() []byte {
return convert.Uint64ToBytes(uint64(s))
}
+// SeriesIDV2 identities a series in a shard.
Review Comment:
We should name it to GlobalSeriesID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
