wu-sheng commented on code in PR #11119:
URL: https://github.com/apache/skywalking/pull/11119#discussion_r1269029129


##########
docs/en/changes/changes.md:
##########
@@ -50,6 +50,7 @@
 * Apply MQE on Virtual-Cache layer UI-templates
 * Add Echo component ID(5015) language: Golang.
 * Fix `index out of bounds exception` in `aggregate_labels` MQE function.
+* Fix Elasticsearch storage TTL timer, move created the latest index before 
retrieval indexes by aliases to avoid the 404 exception. 

Review Comment:
   ```suggestion
   * Move created the latest index before retrieval indexes by aliases to avoid 
the 404 exception. This just prevents some interference from manual operations.
   ```
   
   



##########
docs/en/changes/changes.md:
##########
@@ -50,6 +50,7 @@
 * Apply MQE on Virtual-Cache layer UI-templates
 * Add Echo component ID(5015) language: Golang.
 * Fix `index out of bounds exception` in `aggregate_labels` MQE function.
+* Fix Elasticsearch storage TTL timer, move created the latest index before 
retrieval indexes by aliases to avoid the 404 exception. 

Review Comment:
   First of all, this is unexpected from us that users manually change indices.
   
   Then, @kezhenxu94 retrieve indices by alias without index could cause 404, 
is this an expected ES client behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to