kezhenxu94 commented on PR #11120:
URL: https://github.com/apache/skywalking/pull/11120#issuecomment-1643991139

   > As a quick fix, the current implementation will work. However, I am 
totally with @wu-sheng suggestion to "modularize" it and wanted to suggest more 
or less the same. But as a follow up that could be tackled in the near future.
   > 
   > So, the final solution is to not print any configuration properties, until 
we implement in a standarized way, isn't it?
   
   The logs are printed too early as soon as they are read, before they are 
deserialized into the configuration beans, so there is no way to add an 
annotation to those module config and leverage that annotation to determine 
whether or not to print the logs, if the logs are really needed they must be 
moved to somewhere after the configs are deserialized into the configuration 
beans


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to