jcchavezs commented on code in PR #81:
URL: https://github.com/apache/skywalking-go/pull/81#discussion_r1271534143
##########
tools/go-agent/config/loader.go:
##########
@@ -282,6 +282,20 @@ func (s *StringValue) GetListStringResult() []string {
return strings.Split(val, ",")
}
+// GetListStringResultByLookup get the value from os.LookupEnv, if the env
found, even it's empty
+func (s *StringValue) GetListStringResultByLookup() []string {
Review Comment:
Shall we test this function? I know it is very simple but I can't find a
good reason for not to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
