wu-sheng commented on code in PR #11137:
URL: https://github.com/apache/skywalking/pull/11137#discussion_r1275666082


##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -368,4 +430,5 @@ the sliding window will be destroyed and re-created, 
causing the Alarm of this s
 | Count                | count                      | int            |         
           |
 | Only as condition    | only-as-condition          | boolean        |         
           |
 | Silence period       | silence-period             | int            |         
           |
-| Message              | message                    | string         |         
           |
\ No newline at end of file
+| Message              | message                    | string         |         
           |
+| Specific Hooks       | specific-hooks             | string array   |         
           |

Review Comment:
   I think we don't specific hook name, as users are set the server side as 
known. 



##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -123,13 +129,20 @@ rules:
     silence-period: 5
     message: The request number of entity {name} non-200 status is more than 
expected.
     only-as-condition: false
+    specific-hooks:

Review Comment:
   ```suggestion
      hooks:
   ```
   
   I think hooks is a good name already.



##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -152,7 +165,42 @@ Currently, metrics from the **Service**, **Service 
Instance**, **Endpoint**, **S
 
 Submit an issue or a pull request if you want to support any other scopes in 
Alarm.
 
-## Webhook
+## Hooks
+Hooks are a way to send alarm messages to the outside world. SkyWalking 
supports multiple hooks of the same type, each hook can support different 
configurations. 
+For example, you can configure two Slack hooks, one named `default` and set 
`isGlobal: true` means this hook will apply on all `Alarm Rules` **without 
config** `specific-hooks`.
+Another named `custom1` will only apply on the `Alarm Rules` which **with 
config** `specific-hooks` and include the name `slackHooks.custom1`.
+
+```yaml
+hooks:
+  slackHooks:
+    default:
+      isGlobal: true # if true, this hook will apply on all rules, unless a 
rule has its own specific hook.

Review Comment:
   Will mutiple global rules conflict? Or we will pick one randomly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to