guangdashao commented on PR #142: URL: https://github.com/apache/skywalking-satellite/pull/142#issuecomment-1655110377
> Can you judge the arch in Makefile instead of defining it manually? This is more user-friendly. arch is judged by docker [Multi-platform images](https://docs.docker.com/build/building/multi-platform/) not by me . in Makefile , defined docker PLATFORMS , arguments like TARGETARCH in dockerfile is available automatically inside your Dockerfile and can be leveraged by the processes running as part of your build. ` docker: PLATFORMS = docker: LOAD_OR_PUSH = --load docker.push: PLATFORMS = --platform linux/amd64,linux/arm64 docker.push: LOAD_OR_PUSH = --push .PHONY: docker docker.push docker docker.push: $(DOCKER_RULE) define DOCKER_RULE docker buildx create --use --driver docker-container --name skywalking_satellite > /dev/null 2>&1 || true docker buildx build $(PLATFORMS) $(LOAD_OR_PUSH) \ --no-cache --build-arg VERSION=$(VERSION) \ -t $(HUB)/skywalking-satellite:v$(VERSION) \ -f docker/Dockerfile \ --provenance=false \ . docker buildx rm skywalking_satellite || true endef ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
