weixiang1862 commented on PR #11168:
URL: https://github.com/apache/skywalking/pull/11168#issuecomment-1663099864

   > > > > > I feel good about these screenshots on the Grafana, @wankai123 
WDTY? If you agree, I would ask these to be hosted on website repo.
   > > 
   > > 
   > > > >
   > > 
   > > 
   > > > >
   > > 
   > > 
   > > > > 
![image](https://user-images.githubusercontent.com/16773043/257841287-9d105d3d-39ba-4f12-bb6b-d6bb0dcdb4ed.png)
   > > 
   > > 
   > > > > If the ServiceInstance or Endpoint is `All`, will serviceInstance 
and endpoint label pass to the API handler? Then backend will use `All` as the 
name to build a not existing Id.
   > > 
   > > 
   > > > 
   > > 
   > > 
   > > > I think `All` in the Grafana UI usually means this field has no query 
condition, instead of sending an `All` as a query condition.
   > > 
   > > 
   > > The all option in grafana submit all options sperate by `,` and it is 
not we wanted. So I custom the all value to `blank` and backend filter the 
blank label value(service, endpoint):
   > > 
![image](https://user-images.githubusercontent.com/16346644/257847817-a115a1ba-9d49-433e-b969-23ea2fd6447a.png)
   > 
   > Can we customize the all value to `*`? That's much more understandable
   
   If we all think this is better, I feel good with this too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to