wu-sheng commented on code in PR #11194:
URL: https://github.com/apache/skywalking/pull/11194#discussion_r1287302997


##########
docs/en/api/metrics-query-expression.md:
##########
@@ -206,3 +206,22 @@ aggregate_labels(total_commands_rate, SUM)
 
 ### Result Type
 The ExpressionResultType of the aggregateLabels operation is 
TIME_SERIES_VALUES.
+
+## ViewAsSequence Operation
+ViewAsSequence operation searches for expressions in the given list from start 
to end and returns the expression that not empty.

Review Comment:
   `short-circuit` as the function explanation is good.
   But,  this statement may be not correct. 
   > the result is returned as soon as the first non empty expression is found 
and the remaining expressions will not be evaluated
   
   The return is not as soon as the first not-empty is found. I believe the 
actual execution is getting all expression results first and then check 
according to the seq.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to