hanahmily commented on code in PR #322:
URL:
https://github.com/apache/skywalking-banyandb/pull/322#discussion_r1324528152
##########
banyand/liaison/grpc/discovery.go:
##########
@@ -223,22 +223,25 @@ var _ schema.EventHandler = (*entityRepo)(nil)
type entityRepo struct {
log *logger.Logger
- entitiesMap map[identity]partition.EntityLocator
+ entitiesMap map[identity]*partition.EntityLocator
Review Comment:
Exactly. Please return an empty struct. This struct doesn't contain any
large field, so instantiating it on the stack is not an overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
