simonluo345 commented on PR #11330: URL: https://github.com/apache/skywalking/pull/11330#issuecomment-1718926724
This pull request introduces changes and improvements to the PHP Docker setup and configuration for SkyWalking agent integration: 1. Docker Setup: Updated to PHP 8.1-fpm-bullseye base image. Introduced a builder stage to streamline the build process. Installed Rust and its dependencies, a prerequisite for SkyWalking agent build. Cloned and set the SkyWalking PHP repository to a specified commit. Compiled and installed the SkyWalking agent. Used a multi-stage Docker build to improve the final image size and only carry necessary binaries. 2. Docker Compose: Modified image source to be built from the local context. Added SW_AGENT_PHP_COMMIT as an argument to pass a specific commit of SkyWalking PHP agent. Modified volume mounts for PHP configuration. 3. Entry Point: Introduced an entrypoint script for starting up services (Nginx and PHP-FPM). 4. Nginx Configuration: Added a basic Nginx configuration file to serve PHP applications and pass requests to PHP-FPM. 5. PHP Configuration: Updated the SkyWalking configuration section, segregating settings for general SkyWalking and SkyWalking agent configurations. Adjusted various settings for better integration with SkyWalking. These changes aim to streamline the PHP setup process, improve the integration with SkyWalking, and provide a more robust development and deployment experience. Feedback and reviews are highly appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
