wu-sheng commented on issue #11279: URL: https://github.com/apache/skywalking/issues/11279#issuecomment-1721168258
@yswdqz According to this afternoon discussion, let's submit PRs through this 1. Refactor the codes to move the expected replaced classes/methods out of the original codes. No graalvm-patch relative. 2. Add graalvm-patch(s) to replace classes. We focus on reviewing the new implementation and code generation. After this step, we should be able to compile an `apache-skywalking-apm-pre-graalvm-bin.tar.gz`, which should have classes replaced. 3. Add GraalVM compiling through Maven and CI. This should include the GraalVM agent-generated files, and support to build a MacOS(aarm at least) and Linux(Ubuntu) native binary. Notice, that if we run this on CI, it should mean this build works for Linux(Ubuntu). 4. Begin to add e2e(mostly a copy from existing) to cover OAL relative feature tests for the new images. FYI @kezhenxu94 You may be able to verify intel MacOS compiling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
