[skywalking-banyandb] branch main updated: Fix write response metadata field(measure/stream) (#330)

[hanahmily]

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git


The following commit(s) were added to refs/heads/main by this push:
     new 8996af56 Fix write response metadata field(measure/stream) (#330)
8996af56 is described below

commit 8996af56c3767e339a331f1fab5fd8cc42ca5827
Author: hailin0 <wanghai...@apache.org>
AuthorDate: Sun Sep 17 20:17:15 2023 +0800

    Fix write response metadata field(measure/stream) (#330)
---
 api/proto/banyandb/measure/v1/write.proto | 2 +-
 api/proto/banyandb/stream/v1/write.proto  | 2 +-
 banyand/liaison/grpc/stream.go            | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/api/proto/banyandb/measure/v1/write.proto 
b/api/proto/banyandb/measure/v1/write.proto
index 9d007334..3def9493 100644
--- a/api/proto/banyandb/measure/v1/write.proto
+++ b/api/proto/banyandb/measure/v1/write.proto
@@ -55,7 +55,7 @@ message WriteResponse {
   // status indicates the request processing result
   model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
   // the metadata from request when request fails
-  common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
+  common.v1.Metadata metadata = 3;
 }
 
 message InternalWriteRequest {
diff --git a/api/proto/banyandb/stream/v1/write.proto 
b/api/proto/banyandb/stream/v1/write.proto
index 1c3347f1..01b8f221 100644
--- a/api/proto/banyandb/stream/v1/write.proto
+++ b/api/proto/banyandb/stream/v1/write.proto
@@ -54,7 +54,7 @@ message WriteResponse {
   // status indicates the request processing result
   model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
   // the metadata from request when request fails
-  common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
+  common.v1.Metadata metadata = 3;
 }
 
 message InternalWriteRequest {
diff --git a/banyand/liaison/grpc/stream.go b/banyand/liaison/grpc/stream.go
index d188f975..0fbee9a4 100644
--- a/banyand/liaison/grpc/stream.go
+++ b/banyand/liaison/grpc/stream.go
@@ -99,7 +99,7 @@ func (s *streamService) Write(stream 
streamv1.StreamService_WriteServer) error {
                entity, tagValues, shardID, err := 
s.navigate(writeEntity.GetMetadata(), writeEntity.GetElement().GetTagFamilies())
                if err != nil {
                        s.sampled.Error().Err(err).RawJSON("written", 
logger.Proto(writeEntity)).Msg("failed to navigate to the write target")
-                       reply(nil, modelv1.Status_STATUS_INTERNAL_ERROR, 
writeEntity.GetMessageId(), stream, s.sampled)
+                       reply(writeEntity.GetMetadata(), 
modelv1.Status_STATUS_INTERNAL_ERROR, writeEntity.GetMessageId(), stream, 
s.sampled)
                        continue
                }
                if s.ingestionAccessLog != nil {