kezhenxu94 commented on code in PR #11330:
URL: https://github.com/apache/skywalking/pull/11330#discussion_r1342132664
##########
test/e2e-v2/cases/php/expected/trace-info-detail.yml:
##########
@@ -15,30 +15,34 @@
spans:
{{- contains .spans }}
- - traceid: {{ .traceid }}
- segmentid: {{ .segmentid }}
+ - traceid: "{{ .traceid }}"
+ segmentid: "{{ .segmentid }}"
spanid: {{ .spanid }}
parentspanid: {{ .parentspanid }}
refs: []
servicecode: php
serviceinstancename: {{ notEmpty .serviceinstancename }}
starttime: {{ gt .starttime 0 }}
endtime: {{ gt .endtime 0 }}
- endpointname: /php/info
+ endpointname: POST:/php/info
type: Entry
- peer: {{ notEmpty .peer }}
+ peer: ""
component: PHP
iserror: false
layer: Http
tags:
{{- contains .tags }}
- key: url
value: {{ notEmpty .value }}
+ - key: http.method
+ value: {{ notEmpty .value }}
+ - key: http.status_code
+ value: {{ notEmpty .value }}
Review Comment:
@simonluo345 consider pushing your changes so that I can see where is the
potential problem, one thing I noticed from the screenshot is that you might
wrote some of the expected rules twice like this
<img width="1276" alt="image"
src="https://github.com/apache/skywalking/assets/15965696/4227eade-d8bf-4662-ac61-9d572910147e";>
Not sure though, would be helpful to push the changes here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
