dashanji commented on code in PR #95:
URL: https://github.com/apache/skywalking-swck/pull/95#discussion_r1355968874
##########
operator/apis/operator/v1alpha1/swagent_webhook.go:
##########
@@ -127,10 +127,10 @@ func (r *SwAgent) setOrAddEnv(envKey string, envValue
string) {
}
}
-func (r *SwAgent) setEnvIfExists(envs *[]corev1.EnvVar, envKey string,
envValue string) bool {
+func (r *SwAgent) appendEnvIfExists(envs *[]corev1.EnvVar, envKey string,
envValue string) bool {
for _, env := range *envs {
if strings.EqualFold(env.Name, envKey) {
- env.Value = envValue
+ env.Value += envValue
Review Comment:
I think it's not a good idea to just append the string here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
