hanahmily commented on code in PR #7:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/7#discussion_r1360148924
##########
chart/values.yaml:
##########
@@ -114,6 +115,196 @@ standalone:
# - localhost
# secretName: tls-secret
+cluster:
+ enabled: true
+ liaison:
+ name: banyandb
+ podAnnotations:
+ example: banyandb-foo
+ securityContext: {}
+ # runAsUser: 1000
+ # runAsGroup: 1000
+ # fsGroup: 1000
+ image:
Review Comment:
Image should be under the "cluster". We want the liaison and data to use the
identical image.
##########
chart/values.yaml:
##########
@@ -114,6 +115,196 @@ standalone:
# - localhost
# secretName: tls-secret
+cluster:
+ enabled: true
+ liaison:
+ name: banyandb
+ podAnnotations:
+ example: banyandb-foo
+ securityContext: {}
+ # runAsUser: 1000
+ # runAsGroup: 1000
+ # fsGroup: 1000
+ image:
+ repository: ghcr.io/apache/skywalking-banyandb
+ tag: eecd29e71bc07d07f22aea1496d80dc76a2b2f90
+ pullPolicy: IfNotPresent
+ env: []
+ # - name: BANYANDB_FOO
+ # value: "bar"
+ priorityClassName: ""
+ podDisruptionBudget: {}
+ # minAvailable: 1
+ # maxUnavailable: 2
+ # matchLabels:
+ # - key: foo
+ # value: bar
+ # matchExpressions:
+ # - key: foo
+ # operator: In
+ # values: [bar, baz]
+ # paused: false
+ tolerations: []
+ # - key: foo
+ # value: bar
+ # operator: Equal
+ # effect: NoSchedule
+ nodeSelector: []
+ # - key: foo
+ # value: bar
+ affinity: {}
+ # nodeAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # nodeSelectorTerms:
+ # - matchExpressions:
+ # - key: foo
+ # operator: In
+ # values:
+ # - bar
+ # - baz
+ # podAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # - labelSelector:
+ # matchLabels:
+ # - key: app
+ # value: banyandb
+ # topologyKey: "kubernetes.io/hostname"
+ # namespaces: []
+ resources:
+ requests: []
+ # - key: cpu
+ # value: "100m"
+ # - key: memory
+ # value: "256Mi"
+ limits: []
+ # - key: cpu
+ # value: "500m"
+ # - key: memory
+ # value: "512Mi"
+ tls:
+ grpcSecretName: ""
+ httpSecretName: ""
+
+ grpcSvc:
+ labels: {}
+ annotations: {}
+ port: 17912
+
+ httpSvc:
+ labels: {}
+ annotations: {}
+ port: 17913
+ type: LoadBalancer
+ externalIPs: []
+ loadBalancerIP: null
+ loadBalancerSourceRanges: []
+
+ ingress:
+ enabled: false
+ labels: {}
+ annotations: {}
+ rules: []
+ # - host: localhost
+ # paths:
+ # - path: /
+ # port: 17913
+ # serviceName: banyandb-http
+ tls: []
+ # - hosts:
+ # - localhost
+ # secretName: tls-secret
+
+ data:
+ name: banyandb
+ podAnnotations:
+ example: banyandb-foo
+ securityContext: {}
+ # runAsUser: 1000
+ # runAsGroup: 1000
+ # fsGroup: 1000
+ image:
+ repository: ghcr.io/apache/skywalking-banyandb
+ tag: eecd29e71bc07d07f22aea1496d80dc76a2b2f90
+ pullPolicy: IfNotPresent
+ env: []
+ # - name: BANYANDB_FOO
+ # value: "bar"
+ priorityClassName: ""
+ podDisruptionBudget: {}
+ # minAvailable: 1
+ # maxUnavailable: 2
+ # matchLabels:
+ # - key: foo
+ # value: bar
+ # matchExpressions:
+ # - key: foo
+ # operator: In
+ # values: [bar, baz]
+ # paused: false
+ tolerations: []
+ # - key: foo
+ # value: bar
+ # operator: Equal
+ # effect: NoSchedule
+ nodeSelector: []
+ # - key: foo
+ # value: bar
+ affinity: {}
+ # nodeAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # nodeSelectorTerms:
+ # - matchExpressions:
+ # - key: foo
+ # operator: In
+ # values:
+ # - bar
+ # - baz
+ # podAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # - labelSelector:
+ # matchLabels:
+ # - key: app
+ # value: banyandb
+ # topologyKey: "kubernetes.io/hostname"
+ # namespaces: []
+ resources:
+ requests: []
+ # - key: cpu
+ # value: "100m"
+ # - key: memory
+ # value: "256Mi"
+ limits: []
+ # - key: cpu
+ # value: "500m"
+ # - key: memory
+ # value: "512Mi"
+ tls:
+ grpcSecretName: ""
+ httpSecretName: ""
+
+ grpcSvc:
+ labels: {}
+ annotations: {}
+ port: 17912
+
+ ingress:
Review Comment:
Data nodes are internal nodes, that don't export ports through ingress.
##########
chart/values.yaml:
##########
@@ -114,6 +115,196 @@ standalone:
# - localhost
# secretName: tls-secret
+cluster:
+ enabled: true
+ liaison:
+ name: banyandb
Review Comment:
It should have a "replica" field to scale out/in.
##########
chart/values.yaml:
##########
@@ -114,6 +115,196 @@ standalone:
# - localhost
# secretName: tls-secret
+cluster:
+ enabled: true
+ liaison:
+ name: banyandb
+ podAnnotations:
+ example: banyandb-foo
+ securityContext: {}
+ # runAsUser: 1000
+ # runAsGroup: 1000
+ # fsGroup: 1000
+ image:
+ repository: ghcr.io/apache/skywalking-banyandb
+ tag: eecd29e71bc07d07f22aea1496d80dc76a2b2f90
+ pullPolicy: IfNotPresent
+ env: []
+ # - name: BANYANDB_FOO
+ # value: "bar"
+ priorityClassName: ""
+ podDisruptionBudget: {}
+ # minAvailable: 1
+ # maxUnavailable: 2
+ # matchLabels:
+ # - key: foo
+ # value: bar
+ # matchExpressions:
+ # - key: foo
+ # operator: In
+ # values: [bar, baz]
+ # paused: false
+ tolerations: []
+ # - key: foo
+ # value: bar
+ # operator: Equal
+ # effect: NoSchedule
+ nodeSelector: []
+ # - key: foo
+ # value: bar
+ affinity: {}
+ # nodeAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # nodeSelectorTerms:
+ # - matchExpressions:
+ # - key: foo
+ # operator: In
+ # values:
+ # - bar
+ # - baz
+ # podAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # - labelSelector:
+ # matchLabels:
+ # - key: app
+ # value: banyandb
+ # topologyKey: "kubernetes.io/hostname"
+ # namespaces: []
+ resources:
+ requests: []
+ # - key: cpu
+ # value: "100m"
+ # - key: memory
+ # value: "256Mi"
+ limits: []
+ # - key: cpu
+ # value: "500m"
+ # - key: memory
+ # value: "512Mi"
+ tls:
+ grpcSecretName: ""
+ httpSecretName: ""
+
+ grpcSvc:
+ labels: {}
+ annotations: {}
+ port: 17912
+
+ httpSvc:
+ labels: {}
+ annotations: {}
+ port: 17913
+ type: LoadBalancer
+ externalIPs: []
+ loadBalancerIP: null
+ loadBalancerSourceRanges: []
+
+ ingress:
+ enabled: false
+ labels: {}
+ annotations: {}
+ rules: []
+ # - host: localhost
+ # paths:
+ # - path: /
+ # port: 17913
+ # serviceName: banyandb-http
+ tls: []
+ # - hosts:
+ # - localhost
+ # secretName: tls-secret
+
+ data:
+ name: banyandb
+ podAnnotations:
+ example: banyandb-foo
+ securityContext: {}
+ # runAsUser: 1000
+ # runAsGroup: 1000
+ # fsGroup: 1000
+ image:
+ repository: ghcr.io/apache/skywalking-banyandb
+ tag: eecd29e71bc07d07f22aea1496d80dc76a2b2f90
+ pullPolicy: IfNotPresent
+ env: []
+ # - name: BANYANDB_FOO
+ # value: "bar"
+ priorityClassName: ""
+ podDisruptionBudget: {}
+ # minAvailable: 1
+ # maxUnavailable: 2
+ # matchLabels:
+ # - key: foo
+ # value: bar
+ # matchExpressions:
+ # - key: foo
+ # operator: In
+ # values: [bar, baz]
+ # paused: false
+ tolerations: []
+ # - key: foo
+ # value: bar
+ # operator: Equal
+ # effect: NoSchedule
+ nodeSelector: []
+ # - key: foo
+ # value: bar
+ affinity: {}
+ # nodeAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # nodeSelectorTerms:
+ # - matchExpressions:
+ # - key: foo
+ # operator: In
+ # values:
+ # - bar
+ # - baz
+ # podAffinity:
+ # requiredDuringSchedulingIgnoredDuringExecution:
+ # - labelSelector:
+ # matchLabels:
+ # - key: app
+ # value: banyandb
+ # topologyKey: "kubernetes.io/hostname"
+ # namespaces: []
+ resources:
+ requests: []
+ # - key: cpu
+ # value: "100m"
+ # - key: memory
+ # value: "256Mi"
+ limits: []
+ # - key: cpu
+ # value: "500m"
+ # - key: memory
+ # value: "512Mi"
+ tls:
+ grpcSecretName: ""
+ httpSecretName: ""
Review Comment:
Data nodes don't have http endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
