i7guokui commented on code in PR #115:
URL:
https://github.com/apache/skywalking-client-js/pull/115#discussion_r1361530184
##########
src/performance/fmp.ts:
##########
@@ -137,13 +137,13 @@ class FMPTiming {
const index: number = parseInt(item.ele.getAttribute('fmp_c'), 10);
time = this.statusCollector[index] &&
this.statusCollector[index].time;
} else {
- const match = getStyle(item.ele,
'background-image').match(/url\(\"(.*?)\"\)/);
+ const match = getStyle(item.ele,
'background-image').match(/url\((['"]?)(.*?)\1\)/);
Review Comment:
background-image: url('https://www.example.com/test.png'); // single quotes
background-image: url("https://www.example.com/test.png";); // double quotes
background-image: url(https://www.example.com/test.png); // without any
quotes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://www.example.com/test.png"](https://www.example.com/test.png"){kind=link}