wu-sheng commented on code in PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#discussion_r1365299551
##########
oap-server/server-starter/src/main/resources/oal/java-agent.oal:
##########
@@ -22,6 +22,17 @@ instance_jvm_memory_heap =
from(ServiceInstanceJVMMemory.used).filter(heapStatus
instance_jvm_memory_noheap =
from(ServiceInstanceJVMMemory.used).filter(heapStatus == false).longAvg();
instance_jvm_memory_heap_max =
from(ServiceInstanceJVMMemory.max).filter(heapStatus == true).longAvg();
instance_jvm_memory_noheap_max =
from(ServiceInstanceJVMMemory.max).filter(heapStatus == false).longAvg();
+instance_jvm_memory_pool_code_cache =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.CODE_CACHE_USAGE).longAvg();
+instance_jvm_memory_pool_newgen =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.NEWGEN_USAGE).longAvg();
+instance_jvm_memory_pool_oldgen =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.OLDGEN_USAGE).longAvg();
+instance_jvm_memory_pool_survivor =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.SURVIVOR_USAGE).longAvg();
+instance_jvm_memory_pool_permgen =
from(ServiceInstanceJVMMemoryPool.used).filter(poolType ==
MemoryPoolType.PERMGEN_USAGE).longAvg();
Review Comment:
Why these? All thses are not new metrics.
I am not following.
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/general/general-instance.json:
##########
@@ -326,7 +326,88 @@
]
},
{
- "x": 8,
+ "x": 16,
+ "y": 0,
+ "w": 8,
+ "h": 13,
+ "i": "5",
+ "type": "Widget",
+ "widget": {
+ "title": "JVM Memory Detail (MB)"
Review Comment:
Are you adding a new widget?
This name doesn't seem diff from other GC model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
