liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367827685


##########
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##########
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
 
 # Metrics Rules
 metricsRules:
-  # Cache Metrics
-  - name: cache_evictions
-    exp: pulsar_ml_cache_evictions.sum(['cluster', 'broker'])
-  - name: cache_inserted_entries
-    exp: pulsar_ml_cache_inserted_entries_total.sum(['cluster', 'broker'])
-  - name: cache_evicted_entries
-    exp: pulsar_ml_cache_evicted_entries_total.sum(['cluster', 'broker'])
-  - name: cache_entries
-    exp: pulsar_ml_cache_entries.sum(['cluster', 'broker'])
-  - name: cache_hits_rate
-    exp: pulsar_ml_cache_hits_rate.sum(['cluster', 'broker'])
-  - name: cache_hits_throughput
-    exp: pulsar_ml_cache_hits_throughput.sum(['cluster', 'broker'])
-  - name: cache_misses_rate
-    exp: pulsar_ml_cache_misses_rate.sum(['cluster', 'broker'])
-  - name: cache_misses_throughput
-    exp: pulsar_ml_cache_misses_throughput.sum(['cluster', 'broker'])
-

Review Comment:
   They only have the cluster label. And these are not too important metrics. 
Therefore, it is not displayed in the pulsar cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to