peachisai commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1370236560
########## test/plugin/scenarios/netty-http-4.1.x-scenario/config/expectedData.yaml: ########## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +segmentItems: + - serviceName: netty-http-4.1.x-scenario + segmentSize: gt 0 + segments: + - segmentId: not null + spans: + - operationName: HEAD:/case/healthCheck + parentSpanId: -1 + spanId: 0 + spanLayer: Http + startTime: not null + endTime: not null + componentId: 14 + isError: false + spanType: Entry + peer: '' + tags: + - { key: url, value: not null } + - { key: http.method, value: HEAD } + - { key: http.status_code, value: '200' } + skipAnalysis: 'false' + - segmentId: not null + spans: + - operationName: Netty-http:/user + parentSpanId: -1 + spanId: 0 + spanLayer: Http + startTime: not null + endTime: not null + componentId: 151 + isError: false + spanType: Entry + peer: '' + skipAnalysis: 'false' + tags: + - { key: http.method, value: POST } + - { key: url, value: https://127.0.0.1:8070/user } + - { key: http.body, value: "{\"name\":\"david\",\"age\":30}" } + - { key: http.status_code, value: '200' } + refs: + - { parentEndpoint: Netty-http:/user, networkAddress: 'localhost:8070', + refType: CrossProcess, parentSpanId: 0, parentTraceSegmentId: not null, parentServiceInstance: not + null, parentService: netty-http-4.1.x-scenario, traceId: not null } + - segmentId: not null + spans: + - operationName: Netty-http:/user Review Comment: > Is this a timer-driven? > > Usually, plugin test should be driven by the test framework, URI=`/netty-http-4.1.x-case`. This URI<1> should lead to an entry span, then an exit span to call another URI<2> to test cross-process propagation. In the test URI <1> and <2> could be in one service, but let's make sure you are following the general workflow. 1.It is not a timer-driven 2.The workflow: GET:/netty-http-4.1.x-scenario/case/netty-http-4.1.x-case->Netty-http:/user exist span->Netty-http:/user entry span Do I need to fix something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
