wu-sheng commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1375380313
########## apm-sniffer/optional-plugins/netty-http-4.1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/http/config/NettyHttpPluginConfig.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.plugin.netty.http.config; + +import org.apache.skywalking.apm.agent.core.boot.PluginConfig; + +public class NettyHttpPluginConfig { + + public static class Plugin { + + @PluginConfig(root = NettyHttpPluginConfig.class) + public static class NettyHttp { + + /** + * This config item controls that whether the Netty Http plugin should collect the http body of the request. + */ + public static boolean COLLECT_REQUEST_BODY = false; + + /** + * When either {@link Plugin.NettyHttp#COLLECT_REQUEST_BODY} is enabled, how many characters to keep and send to the OAP + * backend, use negative values to keep and send the complete body. Review Comment: ```suggestion * If {@link Plugin.NettyHttp#COLLECT_REQUEST_BODY} is enabled, * this limitation threshold controls the max size of collected HTTP body. * Use the negative value to represent the unlimited threshold, which could cause OOM. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
