wu-sheng commented on code in PR #656:
URL: https://github.com/apache/skywalking-java/pull/656#discussion_r1422042611
##########
apm-sniffer/bootstrap-plugins/jdk-forkjoinpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/forkjoinpool/define/ForkJoinWorkerQueueInstrumentation.java:
##########
@@ -33,6 +33,9 @@ public class ForkJoinWorkerQueueInstrumentation extends
ClassInstanceMethodsEnha
private static final String FORK_JOIN_WORKER_QUEUE_CLASS =
"java.util.concurrent.ForkJoinPool$WorkQueue";
private static final String FORK_JOIN_WORKER_QUEUE_RUN_TASK_METHOD =
"runTask";
+
+ private static final String FORK_JOIN_WORKER_QUEUE_RUN_TASK_METHOD_JDK11 =
"topLevelExec";
Review Comment:
Please add comments about why there are two methods to intercept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]