marcanpilami commented on issue #11662:
URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858909055

   Thanks. However it may not be needed. If I manually add a call to 
`ClientMonitor.performance(ClientMonitor.customOptions);` just after 
`ClientMonitor.register(...)` it works. It seems `autoTracePerf` is willigly 
ignored when `enableSPA` is `true`. 
   
   I believe it is worth adding a line to the documentation like "using 
enableSPA will disable automatic performance monitoring, call manually 
ClientMonitor.performance is you wish to re-enable it". (it would be a shame 
for users to miss this, as there is explicit support for SPAs inside 
ClientMonitor.performance so they should be encouraged to activate it). It may 
also be interesting to say in the doc why it is disabled by default in SPAs - 
for this I have no idea.
   
   Beside this doc enhancement, I think this issue may be closed. Thanks a lot 
for your help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to