wu-sheng commented on code in PR #11749:
URL: https://github.com/apache/skywalking/pull/11749#discussion_r1447405603


##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -192,6 +192,14 @@ The Configuration Vocabulary lists all available 
configurations provided by `app
 | -                       | -             | k8sServiceNameRule                 
                                                                                
                                                      | `k8sServiceNameRule` 
allows you to customize the service name in ALS via Kubernetes metadata. The 
available variables are `pod` and `service`. E.g. you can use 
`${service.metadata.name}-${pod.metadata.labels.version}` to append the version 
number to the service name. Note that when using environment variables to pass 
this configuration, use single quotes(`''`) to avoid being evaluated by the 
shell.                                                          | 
K8S_SERVICE_NAME_RULE                                 | 
${pod.metadata.labels.(service.istio.io/canonical-name)}.${pod.metadata.namespace}
           |
 | -                       | -             | istioServiceNameRule               
                                                                                
                                                      | `istioServiceNameRule` 
allows you to customize the service name in ALS via Kubernetes metadata. The 
available variables are `serviceEntry`. E.g. you can use 
`${serviceEntry.metadata.name}-${serviceEntry.metadata.labels.version}` to 
append the version number to the service name. Note that when using environment 
variables to pass this configuration, use single quotes(`''`) to avoid being 
evaluated by the shell.                                               | 
ISTIO_SERVICE_NAME_RULE                               | 
${serviceEntry.metadata.name}.${serviceEntry.metadata.namespace}                
             |
 | -                       | -             | istioServiceEntryIgnoredNamespaces 
                                                                                
                                                      | When looking up service 
informations from the Istio ServiceEntries, some of the ServiceEntries might be 
created in several namespaces automatically by some components, and OAP will 
randomly pick one of them to build the service name, users can use this config 
to exclude ServiceEntries that they don't want to be used. Comma separated.     
                                                                                
                                       | 
SW_ISTIO_SERVICE_ENTRY_IGNORED_NAMESPACES             | -                       
                                                                     |
+| -                       | -             | gRPCHost                           
                                                                                
                                                      | Binding IP of gRPC 
services. Services include gRPC data report and internal communication among 
OAP nodes.                                                                      
                                                                                
                                                                                
                                                                                
                                           | SW_ALS_GRPC_HOST                   
                   | 0.0.0.0. Not Activated                                     
                                  |

Review Comment:
   > Binding IP of gRPC services. Services include gRPC data report and 
internal communication
   
   You forget to update the description, I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to