peachisai commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460526446
##########
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##########
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class<?>[] argumentsTypes, Object ret) throws Throwable {
+ AbstractSpan span = ContextManager.activeSpan();
+ span.prepareForAsync();
ContextManager.stopSpan();
+
+ RFuture<Object> future = (RFuture) ret;
+ CompletableFuture<Object> completableFuture =
future.toCompletableFuture();
+ completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
> `whenComplete`
Yes,you are right.This is a sync call
Concern that ```Redisson``` also use ```whenComplete ``` frequently, i
think it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
